-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate multiplexing #5559
Conversation
9f8084b
to
158a08d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the tests and updated inner type, just left some notes on extracting some parts of the poll loop to methods
91ad39f
to
51855ab
Compare
51855ab
to
a9e36cc
Compare
pub enum EthRlpxConnection { | ||
/// A That only supports the ETH protocol. | ||
EthOnly(Box<EthPeerConnection>), | ||
/// A connection that supports the ETH protocol and __at least one other__ RLPx protocol. | ||
Satellite(Box<EthSatelliteConnection>), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is starting a SatelliteStream
that much overhead when no extra protocols are shared that this enum is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly, because this would involve routing through a channel,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, this looks good, super excited to see multiple caps in practice
After thinking a bit longer about this,
|
polling the main stream that owns the |
refactor some multiplex internals and add test for test protocol.