Fix sink implementation #5594
Merged
Fix sink implementation #5594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested review from
mattsse,
Rjected,
Evalir,
onbjerg,
rkrasiuk and
gakonst
as code owners
rkrasiuk
approved these changes
Nov 27, 2023
|
Great work! Sry, may I ask a non-business related question, what is the special purpose of removing semicolon here? This seems legit, just wondering if this serves some specific purpose or is for syntactical consistency across the repo. |
that was the lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug in shutdown of p2p sink, dropping without calling inner sink's
poll_closemethod. fix docs.