Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use SealedBlockedWithSenders in block-level tracing #5620

Merged
merged 2 commits into from
Nov 29, 2023
Merged

use SealedBlockedWithSenders in block-level tracing #5620

merged 2 commits into from
Nov 29, 2023

Conversation

yash-atreya
Copy link
Contributor

Addresses #5497

Using block_with_senders(blockId) to get SealedBlockWithSenders inside trace_block_until instead of block_by_id which returns SealedBlock.

The need to recover signers during tracing is removed due to this.

mattsse
mattsse approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great
ty!

@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Nov 29, 2023
@mattsse mattsse added this pull request to the merge queue Nov 29, 2023
Merged via the queue into paradigmxyz:main with commit a6ad5ac Nov 29, 2023
27 checks passed
@mattsse mattsse linked an issue Nov 29, 2023 that may be closed by this pull request
Use already recovered transaction during tracing #5497
Closed
@yash-atreya yash-atreya mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use already recovered transaction during tracing
2 participants
@yash-atreya @mattsse