Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): eth state cache args #5664

Merged
merged 1 commit into from
Dec 2, 2023
Merged

feat(cli): eth state cache args #5664

merged 1 commit into from
Dec 2, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Dec 2, 2023

Description

Allow configuring eth state cache through CLI args.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-cli Related to the reth CLI labels Dec 2, 2023
@rkrasiuk rkrasiuk requested a review from mattsse December 2, 2023 09:36
mattsse
mattsse requested changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ensure 0 values are invalid, we should use

value_parser = RangedU32ValueParser::<u32>::new().range(1..)

bin/reth/src/args/rpc_state_cache_args.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/eth-state-cache-args branch from db76e12 to 195ac96 Compare December 2, 2023 09:48
mattsse
mattsse approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk force-pushed the rkrasiuk/eth-state-cache-args branch from 195ac96 to 9e9cc35 Compare December 2, 2023 11:02
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/eth-state-cache-args branch from 9e9cc35 to d9fef1a Compare December 2, 2023 11:09
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/eth-state-cache-args branch from d9fef1a to 01d6e59 Compare December 2, 2023 11:21
@rkrasiuk rkrasiuk added this pull request to the merge queue Dec 2, 2023
Merged via the queue into main with commit 6b06382 Dec 2, 2023
27 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/eth-state-cache-args branch December 2, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse