Fix eth message ID length bug #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Ah okay I understand this.
we we're previously assuming the total number of message ids determine the offset, but it's how many message ids does the capability need instead.
since Receipts is the highest (supported by all versions) its Receipts.id + 1
nice find.
only doc nit
thanks @mattsse :) |
mattsse
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regardless of how many messages are used in an eth version, the message ID for receipts doesn't change. 17 values are needed to cover the eth message ID range 0x00 - 0x10. previously the number of messages used for a version has been used. this will result in bugs calculating offset when eth is preceded by another cap in the message id.
this pr is a product of #5577 and is a subtask of #791.