Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive reorg log #5671

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Dec 4, 2023

Closes #5427

Added "Reorg" explicitly to the log message and included words in the function name to make it easier to find/grep.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

wdyt @rkrasiuk ?

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Dec 4, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a smol change for cargo fmt

crates/blockchain-tree/src/blockchain_tree.rs Outdated Show resolved Hide resolved
crates/blockchain-tree/src/blockchain_tree.rs Outdated Show resolved Hide resolved
mattsse and others added 3 commits December 15, 2023 14:06
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@mattsse mattsse added this pull request to the merge queue Dec 15, 2023
Merged via the queue into paradigmxyz:main with commit 84b1bb0 Dec 15, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More descriptive reorg logs
3 participants