Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use human_bytes for snapshot sizes #5675

Merged
merged 2 commits into from
Dec 4, 2023
Merged

chore: use human_bytes for snapshot sizes #5675

merged 2 commits into from
Dec 4, 2023

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Dec 4, 2023

Uses human_bytes to display snapshot file sizes like we do for table sizes

@onbjerg onbjerg added C-debt Refactor of code section that is hard to understand or maintain A-cli Related to the reth CLI labels Dec 4, 2023
@mattsse mattsse added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit dffa462 Dec 4, 2023
27 checks passed
@mattsse mattsse deleted the onbjerg/snapshot-sizes branch December 4, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onbjerg @mattsse @joshieDo