Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin) enhance logging config to make RUST_LOG for journalId and File writers #5687

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

@DoTheBestToGetTheBest DoTheBestToGetTheBest commented Dec 4, 2023

Resolves #5685

@rkrasiuk rkrasiuk linked an issue Dec 6, 2023 that may be closed by this pull request
1 task
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can we initialize the EnvFilter with from_env_lossy, and then use add_directive to add DEFAULT_ENV_FILTER_DIRECTIVE and filter from arguments?

add_directive works by overwriting existing spans and events: https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#method.add_directive

@DoTheBestToGetTheBest
Copy link
Contributor Author

nt / clippy / ethereum (pull_reque

ty for your review and your help, changed file :)

Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits!

bin/reth/src/cli/mod.rs Outdated Show resolved Hide resolved
bin/reth/src/cli/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
@DoTheBestToGetTheBest
Copy link
Contributor Author

LGTM, only nits!

ty so much !

@DoTheBestToGetTheBest
Copy link
Contributor Author

@DoTheBestToGetTheBest FYI to close issues automatically https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

sorry didn't see your post, ty lot for this one, didn't know this is possible :)

Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Really clean change.

@shekhirin shekhirin added this pull request to the merge queue Dec 11, 2023
Merged via the queue into paradigmxyz:main with commit 1e52304 Dec 11, 2023
27 checks passed
@DoTheBestToGetTheBest
Copy link
Contributor Author

LGTM, thank you! Really clean change.

ty sir, appreciate lot

shekhirin added a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Journald and file log writers ignore RUST_LOG environment variable
3 participants