-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base sepolia support #5697
Conversation
Thanks for the PR! Will review after work today. |
I'm testing running this but unluckily it doesn't advance blocks Here is our op-node logs
op-reth logs
|
Still got the error which is nonsense as it error about BlockGasUsed op-geth
op-node
|
Gotcha! I can take a look this weekend. In the meantime, is your L1 Sepolia node an archive node? |
It's a quicknode one (50$/month plan) which should be an archive node |
Any update here? 🙂 |
Sync version
https://base-sepolia.blockscout.com/block/1 Block hash: 0x44b31f42f3327b2497c94acd1d62dd3965b23da06268316e6085dbaf9900c22c But in reth it says 0x44b52cadd963750a046be3fa0e4f520fa2d4d22b5222e1a8034295c9d2fc6b6c which is invalid |
the gas mismatch is very odd, not sure where the (gas_used: 1000000) gas_used is coming from? but this is wrong? if I query the first base sepolia block: I get gas used by the block: and for the systemTx: @Chomtana if I read the logs correctly then it looks like the op-node sends an invalid payload to op-reth? hmm, this entire setup is very confusing to me, why is there payload building involved here? |
Update: I think I've found the bug; regolith is timestamp based hardfork and must be initialized as such, see also BASE_MAINNET: this would explain the wrong gas_used because there are no refunds if regolith is not activated. mind giving this another try @Chomtana ? |
Testing now. Thank you very much |
@mattsse it's looking good rethop-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
in that case, happy to include this, all chainspec values look fine to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for losing track of this; Thought I squared away my todo list prior to logging off for the holidays 😅
Good catch @mattsse; LGTM.
I have added base sepolia support to reth which should fixes #5653
However, I have not added test cases yet as I don't know how to get base_sepolia_forkids. It would be great if team can advise me on this.
If this looks good will proceed with op sepolia support.