perf: misc changes #5701
Merged
perf: misc changes #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/random-perf
branch
from
3feffca
to
ff56c7f
Compare
DaniPopes
force-pushed
the
dani/random-perf
branch
from
ff56c7f
to
0f686d7
Compare
rkrasiuk
added
C-perf
rkrasiuk
approved these changes
Dec 5, 2023
Comment on lines
+189
to
+190
| // We don't know the length of the element until we compact it. | ||
| let mut tmp = Vec::with_capacity(64); |
There was a problem hiding this comment.
would appreciate a comment on why 64
There was a problem hiding this comment.
Don't know either, I didn't write this code
There was a problem hiding this comment.
missed that it was already there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.