Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(provider): better observability on append #5703

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore(provider): better observability on append #5703

merged 1 commit into from
Dec 6, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Dec 6, 2023

Description

  • Dedup new_tip_number and last_block_number
  • Display block range on Appended blocks log
  • Log attempt to append empty block range

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools labels Dec 6, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 857f907 Dec 6, 2023
27 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/append-better-logs branch December 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse Awaiting requested review from mattsse

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @shekhirin