Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use receover_signer_unchecked for tx receipt #5715

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 8, 2023

fixes a but where we currently cant return the receipt of transactions that have a s value > secp256k1n / 2 pre EIP-2.

such as https://etherscan.io/getRawTx?tx=0x9e6e19637bb625a8ff3d052b7c2fe57dc78c55a15d258d77c43d5a9c160b0384

fix

use unchecked recovery when building the tx receipt

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Dec 8, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah rip, yeah missed this one, nice catch

@mattsse mattsse added this pull request to the merge queue Dec 9, 2023
Merged via the queue into main with commit 8a670d5 Dec 9, 2023
27 checks passed
@mattsse mattsse deleted the matt/use-recover-unchecked-for-tx.receipt branch December 9, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants