refactor(net): Simplified logic for determining shared capability versions #5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Dec 11, 2023
Comment on lines
482
to
483
| if peer_capability.version > | ||
| shared_capabilities.get(&peer_capability.name).map(|v| v.version).unwrap_or(0) |
There was a problem hiding this comment.
there's an edge case here when the shared version == 0.
I'd like to see a test for a cap with version 0 and I think we can fix this by moving the comparison into the map and use map_or(true, )
There was a problem hiding this comment.
@mattsse Done, tell me what you think about this.
mattsse
added
the
C-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the logic to determine shared capability versions, replacing complex conditionals with a more concise approach using
Option'smap_orandunwrap_or. This enhances readability and maintainability while achieving the same functionality.