Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): added NetworkConfigBuilder.block_import(..) #5783

Merged
merged 3 commits into from
Dec 15, 2023
Merged

feat(network): added NetworkConfigBuilder.block_import(..) #5783

merged 3 commits into from
Dec 15, 2023

Conversation

lmittmann
Copy link
Contributor

@lmittmann lmittmann commented Dec 15, 2023 •
edited
Loading

This PR adds a block_import(..) option to the NetworkConfigBuilder and exports import and message so one can build custom implementations of the BlockImport-trait.

mattsse
mattsse approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@mattsse mattsse added this pull request to the merge queue Dec 15, 2023
Merged via the queue into paradigmxyz:main with commit 686129c Dec 15, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmittmann @mattsse @DaniPopes