Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use existing fn for loading network secret key #5961

Merged
merged 1 commit into from
Jan 7, 2024
Merged

chore: use existing fn for loading network secret key #5961

merged 1 commit into from
Jan 7, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 6, 2024

use existing fn that does the same thing

@mattsse mattsse requested a review from onbjerg as a code owner January 6, 2024 13:35
@mattsse mattsse requested a review from Rjected January 6, 2024 13:35
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jan 6, 2024
Rjected
Rjected approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, is currently duplication

@mattsse mattsse added this pull request to the merge queue Jan 7, 2024
Merged via the queue into main with commit 434b43a Jan 7, 2024
27 checks passed
@mattsse mattsse deleted the matt/chore-use-existing-fn-for-network-secret branch January 7, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected