Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add non critical spawn with graceful shutdown signal fn #5962

Merged
merged 2 commits into from
Jan 8, 2024
Merged

chore: add non critical spawn with graceful shutdown signal fn #5962

merged 2 commits into from
Jan 8, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 6, 2024

adds a non critical variant that spawns with shutdown signal, a panicking task will not terminate the executor

@mattsse mattsse requested a review from Rjected January 6, 2024 13:43
@mattsse mattsse added the C-enhancement New feature or request label Jan 6, 2024
Rjected
Rjected approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just thinking it should be added to the TaskSpawnerExt trait since spawn_critical_with_graceful_shutdown_signal is there as well

crates/tasks/src/lib.rs
/// });
/// # }
/// ```
pub fn spawn_with_graceful_shutdown_signal<F>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be added to TaskSpawnerExt too?

rkrasiuk
rkrasiuk approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo @Rjected's comment

@mattsse mattsse enabled auto-merge January 8, 2024 10:58
@mattsse mattsse added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 8d6880c Jan 8, 2024
27 checks passed
@mattsse mattsse deleted the matt/chore-add-non-critical-spawn-graceful branch January 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @Rjected @rkrasiuk