Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): debug replay engine #5972

Merged
merged 10 commits into from
Jan 9, 2024
Merged

feat(cli): debug replay engine #5972

merged 10 commits into from
Jan 9, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Jan 8, 2024

Description

Introduces an Engine API interceptor, which persists them to disk, and a new debug routine, which replays persisted messages in the order they were received.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-cli Related to the reth CLI labels Jan 8, 2024
mattsse
mattsse requested changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this approach makes sense to me.

we could also support this via server middleware but this would be more work, can open a good first issue for this feature though

crates/rpc/rpc-types/src/eth/engine/cancun.rs Show resolved Hide resolved
bin/reth/src/commands/debug_cmd/replay_engine.rs Show resolved Hide resolved
bin/reth/src/commands/debug_cmd/replay_engine.rs Outdated Show resolved Hide resolved
bin/reth/src/commands/debug_cmd/replay_engine.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk requested a review from mattsse January 8, 2024 21:26
mattsse
mattsse approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit ac104d0 Jan 9, 2024
27 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/debug-replay-engine branch January 9, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@Evalir Evalir Awaiting requested review from Evalir

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse