-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): log tx opening location #5973
Conversation
332069b
to
904f330
Compare
904f330
to
6244331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
send
concerned about slowdown during |
okay, false alarm, they originated in RPC requests coming from Teku |
To be able to catch the leaked transactions, we need to know their origin. Having a caller tracked up to the provider and the transaction ID should be enough.
The runtime cost of
#[track_caller]
should be negligible. No stack walk happens during the caller retrieval, and instead the caller is passed as an additional argument to the function. See https://rustc-dev-guide.rust-lang.org/backend/implicit-caller-location.html#generating-code-for-track_caller-callees for more information.