Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tracing): allow tracer init to fail #5988

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

shekhirin
Copy link
Collaborator

Thanks @Rjected for pointing out

failures:

---- cli::tests::override_trusted_setup_file stdout ----
thread 'cli::tests::override_trusted_setup_file' panicked at /Users/shekhirin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-subscriber-0.3.18/src/util.rs:91:14:
failed to set global default subscriber: SetGlobalDefaultError("a global default trace dispatcher has already been set")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@shekhirin shekhirin added A-observability Related to tracing, metrics, logs and other observability tools C-test A change that impacts how or what we test labels Jan 9, 2024
@shekhirin shekhirin requested a review from Rjected January 9, 2024 18:47
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shekhirin shekhirin added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 467c22b Jan 9, 2024
27 checks passed
@shekhirin shekhirin deleted the alexey/fix-tracer-init branch January 9, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants