Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lru cache to match docs #5995

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix lru cache to match docs #5995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/net/network/src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ impl<T: Hash + Eq> LruCache<T> {
if self.inner.insert(entry) {
if self.limit.get() == self.inner.len() {
// remove the oldest element in the set
self.remove_lru();
_ = self.remove_lru();
}
return true
}
Expand All @@ -40,8 +40,8 @@ impl<T: Hash + Eq> LruCache<T> {
///
/// If the `LruCache` is empty this will return None.
#[inline]
fn remove_lru(&mut self) {
self.inner.pop_front();
fn remove_lru(&mut self) -> Option<T> {
self.inner.pop_front()
}

/// Returns `true` if the set contains a value.
Expand Down
Loading