Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FileClient and BlockFileCodec out of test-utils #5998

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Move FileClient and BlockFileCodec out of test-utils #5998

merged 5 commits into from
Jan 10, 2024

Conversation

tcoratger
Copy link
Contributor

Should close #5994.

@mattsse mattsse requested a review from Rjected January 10, 2024 09:23
@mattsse mattsse added the C-debt A clean up/refactor of existing code label Jan 10, 2024
Rjected
Rjected requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit about docs, otherwise this looks good to me!

It should also be possible to remove the test-utils feature from bin/reth/Cargo.toml

crates/net/downloaders/src/lib.rs Outdated Show resolved Hide resolved
@tcoratger @Rjected
Update crates/net/downloaders/src/lib.rs
e2c7881 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@Rjected
Copy link
Member

Rjected commented Jan 10, 2024

whoops, should have been [FileClient](file_client::FileClient) and [BlockFileCodec](file_codec::BlockFileCodec)

@tcoratger
Copy link
Contributor Author

whoops, should have been [FileClient](file_client::FileClient) and [BlockFileCodec](file_codec::BlockFileCodec)

@Rjected Yep just fixed it plus Cargo dependencies.

Rjected
Rjected approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Rjected Rjected added this pull request to the merge queue Jan 10, 2024
Merged via the queue into paradigmxyz:main with commit 26e31f3 Jan 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk left review comments

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move FileClient and BlockFileCodec out of test-utils
4 participants
@tcoratger @Rjected @rkrasiuk @mattsse