Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix clippy warnings for windows #6005

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jan 10, 2024

warning: unused imports: `MDBX_env`, `MDBX_hsr_func`, `MDBX_txn`, `mdbx_pid_t`, `mdbx_tid_t`
 --> crates/storage/libmdbx-rs/src/environment.rs:9:11
  |
9 | use ffi::{mdbx_pid_t, mdbx_tid_t, MDBX_env, MDBX_hsr_func, MDBX_txn};
  |           ^^^^^^^^^^  ^^^^^^^^^^  ^^^^^^^^  ^^^^^^^^^^^^^  ^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

   Compiling boa_macros v0.17.3
warning: field `handle_slow_readers` is never read
   --> crates/storage/libmdbx-rs/src/environment.rs:598:5
    |
585 | pub struct EnvironmentBuilder {
    |            ------------------ field in this struct
...
598 |     handle_slow_readers: Option<HandleSlowReadersCallback>,
    |     ^^^^^^^^^^^^^^^^^^^
warning: unused import: `HandleSlowReadersReturnCode`
  --> crates/storage/db/src/implementation/mdbx/mod.rs:15:61
   |
15 |     DatabaseFlags, Environment, EnvironmentFlags, Geometry, HandleSlowReadersReturnCode, Mode,
   |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `warn`
  --> crates/storage/db/src/implementation/mdbx/mod.rs:18:36
   |
18 | use reth_tracing::tracing::{error, warn};
   |                                    ^^^^

warning: constant `MAX_SAFE_READER_SPACE` is never used
  --> crates/storage/db/src/implementation/mdbx/mod.rs:33:7
   |
33 | const MAX_SAFE_READER_SPACE: usize = 10 * GIGABYTE;
   |       ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: static `PROCESS_ID` is never used
  --> crates/storage/db/src/implementation/mdbx/mod.rs:35:8
   |
35 | static PROCESS_ID: Lazy<u32> = Lazy::new(|| {
   |        ^^^^^^^^^^
warning: unused import: `gauge`
 --> bin/reth/src/prometheus_exporter.rs:8:31
  |
8 | use metrics::{describe_gauge, gauge};
  |                               ^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `tracing::error`
  --> bin/reth/src/prometheus_exporter.rs:14:5
   |
14 | use tracing::error;
   |     ^^^^^^^^^^^^^^

@shekhirin shekhirin added the C-debt A clean up/refactor of existing code label Jan 10, 2024
@shekhirin shekhirin force-pushed the alexey/windows-clippy branch from 7ff38a2 to f0abd0b Compare January 10, 2024 12:39
@shekhirin shekhirin marked this pull request as ready for review January 10, 2024 12:56
@shekhirin shekhirin added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 56a3548 Jan 10, 2024
27 checks passed
@shekhirin shekhirin deleted the alexey/windows-clippy branch January 10, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants