Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): snapshot up to the best block number, not last #6042

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

shekhirin
Copy link
Collaborator

Creating static files up to the last_block_number may be incorrect if the pipeline didn't finish running all stages and we have full headers, but partial transactions or receipts in the database.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI A-static-files Related to static files labels Jan 12, 2024
@gakonst gakonst added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit e67567c Jan 12, 2024
27 checks passed
@gakonst gakonst deleted the alexey/fix-cli-snapshot-range branch January 12, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-static-files Related to static files C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants