Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node-builder): make DB generic Unpin in node components #6227

Merged
merged 2 commits into from
Jan 25, 2024
Merged

chore(node-builder): make DB generic Unpin in node components #6227

merged 2 commits into from
Jan 25, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Make DB generic Unpin in node components.

@rkrasiuk rkrasiuk requested review from Rjected and mattsse January 25, 2024 17:44
@rkrasiuk rkrasiuk requested a review from gakonst as a code owner January 25, 2024 17:44
mattsse
mattsse approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I also made this in #5932 somewhere

@rkrasiuk rkrasiuk enabled auto-merge January 25, 2024 17:53
@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 720815a Jan 25, 2024
28 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/make-db-unpin branch January 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse