feat(snapshot, prune): headers #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/snapshotter-headers
branch
3 times, most recently
from
e3d9b37
to
a54b538
Compare
shekhirin
force-pushed
the
alexey/snapshotter-headers
branch
from
99077c4
to
f93a730
Compare
Base automatically changed from
alexey/snapshotter-transactions
to
joshie/tx-snap-sync
January 26, 2024 12:35
shekhirin
force-pushed
the
alexey/snapshotter-headers
branch
from
f93a730
to
909be48
Compare
onbjerg
reviewed
Jan 29, 2024
| @@ -228,8 +218,6 @@ impl<'a> SnapshotProviderRW<'a> { | |||
| ) -> ProviderResult<BlockNumber> { | |||
| debug_assert!(self.writer.user_header().segment() == SnapshotSegment::Headers); | |||
|
|
|||
| self.writer.user_header_mut().increment_block(); | |||
There was a problem hiding this comment.
Are we not supposed to increment the block here as we append a new header?
There was a problem hiding this comment.
increment is done now outside of this method, just as for append_receipt and append_transaction methods:
reth/crates/snapshot/src/segments/headers.rs
Lines 52 to 55 in ee9265b
@joshieDo has some improvements to append_header method in #6273, will re-use these changes once his PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6122
Some changes to
init_genesiswere required to take static files into account when checking the genesis header.