-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snapshot, stages): snapshot stage #6248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/snapshot-stage
branch
from
January 29, 2024 16:36
e39f409
to
f1aa297
Compare
shekhirin
force-pushed
the
alexey/snapshot-stage
branch
from
January 29, 2024 18:56
aefe1dd
to
a67ebec
Compare
shekhirin
force-pushed
the
alexey/snapshot-stage
branch
from
January 29, 2024 19:24
466a719
to
fb77c95
Compare
shekhirin
requested review from
joshieDo,
rkrasiuk,
mattsse,
Rjected,
rakita,
onbjerg and
gakonst
as code owners
January 29, 2024 20:26
mattsse
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems reasonable, pending @onbjerg
onbjerg
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm minus the comment @mattsse left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a scenario when we have data in the database for
finalized..=tip
blocks, turn off the node, turn it on again, and pipeline starts, writing to static files. The problem is that data in the database was never moved to static files.This PR introduces a separate pipeline stage that copies all (even non-finalized, and it's fine because we can unwind from static files) data from the database to static files. The actual deletion will be done by pruner, as before.
reth/crates/stages/src/stages/snapshot.rs
Lines 7 to 10 in fb77c95
Tested on Holesky by taking a database generated with
main
branch, unwinding it by 1000 blocks, and starting the node onalexey/snapshot-stage
branch. It triggers the pipeline, and theSnapshot
stage moves all data from database to static files.