Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stages): division by zero in headers progress #6262

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(stages): division by zero in headers progress #6262

merged 1 commit into from
Jan 29, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jan 28, 2024 •
edited
Loading

Fixes panics in remainder

reth/crates/stages/src/stages/headers.rs

Line 127 in c552897

if index > 0 && index % interval == 0 {

reth/crates/stages/src/stages/headers.rs

Line 180 in c552897

if index > 0 && index % interval == 0 {

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-staged-sync Related to staged sync (pipelines and stages) labels Jan 28, 2024
mattsse
mattsse reviewed Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear what the fix is here

crates/stages/src/stages/headers.rs Show resolved Hide resolved
mattsse
mattsse approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it now, thanks

@shekhirin shekhirin merged commit f64d7ab into feat/static-files Jan 29, 2024
24 checks passed
@shekhirin shekhirin deleted the alexey/headers-div-zero branch January 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

@onbjerg onbjerg Awaiting requested review from onbjerg

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse