Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include apache licenced fastrlp as reth-rlp #63

Merged
merged 3 commits into from
Oct 14, 2022
Merged

include apache licenced fastrlp as reth-rlp #63

merged 3 commits into from
Oct 14, 2022

Conversation

rakita
Copy link
Collaborator

@rakita rakita commented Oct 13, 2022

Including apache licenced fastrlp from here: https://docs.rs/fastrlp/0.1.2/fastrlp/index.html

Bloom filters need to be enabled behind ethereum-types, they are not commented out.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no authors in the original: https://docs.rs/crate/fastrlp/0.1.2/source/Cargo.toml.orig

should we make a note in the readme?

@rakita
Copy link
Collaborator Author

rakita commented Oct 13, 2022

Will add the note

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We'll need to derive this in ethers core types though? If we're doing this, maybe we should just sprint on ruint usage over Primitive Types & Ethers Core? And get this fastrlp there?

@onbjerg onbjerg added C-enhancement New feature or request A-utils Related to commonly used utilities labels Oct 14, 2022
@rakita rakita merged commit 92e64ed into main Oct 14, 2022
@rakita rakita deleted the rakita/rlp branch October 14, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-utils Related to commonly used utilities C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants