Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin): delete snapshot jars in stage drop #6307

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jan 31, 2024

This PR makes reth stage drop delete static files for the associated segments:

let snapshot_segment = match self.stage {
StageEnum::Headers => Some(SnapshotSegment::Headers),
StageEnum::Bodies => Some(SnapshotSegment::Transactions),
StageEnum::Execution => Some(SnapshotSegment::Receipts),
_ => None,
};

@shekhirin shekhirin changed the title feat(bin): drop jars in stage drop feat(bin): drop snapshot jars in stage drop Jan 31, 2024
@shekhirin shekhirin changed the title feat(bin): drop snapshot jars in stage drop feat(bin): delete snapshot jars in stage drop Jan 31, 2024
@shekhirin shekhirin added C-enhancement New feature or request A-cli Related to the reth CLI A-static-files Related to static files labels Jan 31, 2024
@shekhirin shekhirin marked this pull request as ready for review January 31, 2024 18:45
@shekhirin shekhirin marked this pull request as draft January 31, 2024 19:25
@shekhirin shekhirin marked this pull request as ready for review January 31, 2024 19:48
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin merged commit b499acc into feat/static-files Feb 2, 2024
24 checks passed
@shekhirin shekhirin deleted the alexey/stage-drop-snapshots branch February 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants