-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bin): db get
for snapshots
#6465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shekhirin
commented
Feb 7, 2024
•
edited
Loading
edited
shekhirin
force-pushed
the
alexey/db-get-snapshots
branch
from
February 8, 2024 12:54
b1e5d71
to
97b9a4d
Compare
shekhirin
force-pushed
the
feat/static-files
branch
5 times, most recently
from
February 8, 2024 17:03
dd6aa63
to
613f319
Compare
Should this say |
IMO we want to be explicit about the source of data for debugging purposes |
shekhirin
added
A-cli
Related to the reth CLI
A-static-files
Related to static files
C-enhancement
New feature or request
labels
Feb 9, 2024
onbjerg
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, agree wrt being explicit about the data source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-cli
Related to the reth CLI
A-static-files
Related to static files
C-enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.