Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitives): implement Display for SegmentRangeInclusive #6488

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

shekhirin
Copy link
Collaborator

Before

reth (feat/static-files) cargo run --quiet --bin reth -- db stats --chain holesky --only-total-size
| Segment      | Block Range                                          | Transaction Range                                       | Shape        | Size       |
|--------------|------------------------------------------------------|---------------------------------------------------------|--------------|------------|
| Headers      | SegmentRangeInclusive { start: 0, end: 499999 }      | N/A                                                     | 3 x 500000   | 281.5 MiB  |
| Headers      | SegmentRangeInclusive { start: 500000, end: 834214 } | N/A                                                     | 3 x 334215   | 189.5 MiB  |
| Transactions | SegmentRangeInclusive { start: 0, end: 499999 }      | SegmentRangeInclusive { start: 0, end: 1903501 }        | 1 x 1903502  | 678.7 MiB  |
| Transactions | SegmentRangeInclusive { start: 500000, end: 850110 } | SegmentRangeInclusive { start: 1903502, end: 26189416 } | 1 x 24285915 | 5.6 GiB    |
| Receipts     | SegmentRangeInclusive { start: 0, end: 499999 }      | SegmentRangeInclusive { start: 0, end: 1903501 }        | 1 x 1903502  | 103.8 MiB  |
| Receipts     | SegmentRangeInclusive { start: 500000, end: 850110 } | SegmentRangeInclusive { start: 1903502, end: 26189416 } | 1 x 24285915 | 1009.5 MiB |
| ------------ | ---------------------------------------------------- | ------------------------------------------------------- | ------------ | ---------- |
| Total        |                                                      |                                                         |              | 7.8 GiB    |

After

reth (alexey/segment-range-inclusive-display) cargo run --quiet --bin reth -- db stats --chain holesky --only-total-size
| Segment      | Block Range     | Transaction Range  | Shape        | Size       |
|--------------|-----------------|--------------------|--------------|------------|
| Headers      | 0..=499999      | N/A                | 3 x 500000   | 281.5 MiB  |
| Headers      | 500000..=834214 | N/A                | 3 x 334215   | 189.5 MiB  |
| Transactions | 0..=499999      | 0..=1903501        | 1 x 1903502  | 678.7 MiB  |
| Transactions | 500000..=850110 | 1903502..=26189416 | 1 x 24285915 | 5.6 GiB    |
| Receipts     | 0..=499999      | 0..=1903501        | 1 x 1903502  | 103.8 MiB  |
| Receipts     | 500000..=850110 | 1903502..=26189416 | 1 x 24285915 | 1009.5 MiB |
| ------------ | --------------- | ------------------ | ------------ | ---------- |
| Total        |                 |                    |              | 7.8 GiB    |

@shekhirin shekhirin added C-enhancement New feature or request A-cli Related to the reth CLI A-static-files Related to static files labels Feb 8, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beauty

@shekhirin shekhirin merged commit ad56b98 into feat/static-files Feb 8, 2024
22 of 24 checks passed
@shekhirin shekhirin deleted the alexey/segment-range-inclusive-display branch February 8, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants