Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin, snapshot, engine): emit and log snapshotter events #6490

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Feb 8, 2024

Similar to pruner events, we want to show snapshotter-related events in logs.

@shekhirin shekhirin added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools A-cli Related to the reth CLI A-static-files Related to static files labels Feb 8, 2024
@shekhirin shekhirin marked this pull request as ready for review February 8, 2024 15:57
@shekhirin shekhirin force-pushed the feat/static-files branch 4 times, most recently from 1a49656 to dd6aa63 Compare February 8, 2024 17:01
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin merged commit 1238e14 into feat/static-files Feb 8, 2024
22 of 24 checks passed
@shekhirin shekhirin deleted the alexey/snapshotter-events branch February 8, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants