Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bin): add snapshot hook to list of hooks #6492

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(bin): add snapshot hook to list of hooks #6492

merged 2 commits into from
Feb 8, 2024

Conversation

shekhirin
Copy link
Collaborator

bin/reth/src/builder.rs got probably incorrectly merged during one of the conflicts, so we created EngineHooks twice and only the PruneHook was in the list.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine A-cli Related to the reth CLI A-static-files Related to static files labels Feb 8, 2024
@shekhirin shekhirin merged commit 8535568 into feat/static-files Feb 8, 2024
23 of 25 checks passed
@shekhirin shekhirin deleted the alexey/init-snapshot-hook branch February 8, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@mattsse mattsse Awaiting requested review from mattsse

@Rjected Rjected Awaiting requested review from Rjected

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-consensus Related to the consensus engine A-static-files Related to static files C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @joshieDo