Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snapshot, stages): pass snapshot target per segment #6673

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Feb 19, 2024

We need to snapshot different segments based on different stage checkpoints. It is be possible for a stage to be lower than the Finish if we drop the stage manually.

@shekhirin shekhirin force-pushed the feat/static-files branch 7 times, most recently from d75d4e3 to 043f07d Compare February 19, 2024 21:44
@shekhirin shekhirin added C-enhancement New feature or request A-static-files Related to static files labels Feb 19, 2024
@shekhirin shekhirin marked this pull request as ready for review February 19, 2024 22:08
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin merged commit 64ddcc5 into feat/static-files Feb 20, 2024
23 of 25 checks passed
@shekhirin shekhirin deleted the alexey/snapshot-stage-targets branch February 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants