fix: SnapshotProvider edge case scenarios on insertion and query
#6707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-bug
joshieDo
force-pushed
the
joshie/manager-issues
branch
from
3e43d1d
to
cf6350c
Compare
mattsse
reviewed
Feb 21, 2024
| result.push(res); | ||
| break 'inner | ||
| } | ||
| None => { | ||
| if retrying { | ||
| let err = if segment.is_headers() { |
There was a problem hiding this comment.
we can, but this is not an actual malfunction, which I kinda associate with a warning.
if the range spans across multiple files, there will be a time when the number no longer belongs to the current file (and thus returning None on the get_fn), and we need to find the associated file provider (get_provider).
With that in mind, do you still want me to add a warn!? Maybe a trace! would be a better fit?
There was a problem hiding this comment.
oh wait you mean inside the if retrying, yeah okay adding
mattsse
approved these changes
Feb 21, 2024
shekhirin
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two edge case scenarios.
get_or_create_jar_provider: change from.inserttoentryapi. Although not encountered, it is possible that two parallel threads reach theself.map.insertalmost at the same time. The first one holding the lock would insert aLoadedJar. The second one once unblocked, would do the same thing invalidating the previousLoadedJarand potentially affecting the first threads task.fetch_range_with_predicate: on a normal node behaviour it shouldn't happen, but when testing stuff out we have encountered this.