chore: remove static file commit() from inside the stage
#6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-staged-sync
joshieDo
requested review from
rakita,
onbjerg,
rkrasiuk and
shekhirin
as code owners
mattsse
approved these changes
Feb 22, 2024
| @@ -85,7 +85,6 @@ impl<DB: Database> DerefMut for DatabaseProviderRW<DB> { | |||
| impl<DB: Database> DatabaseProviderRW<DB> { | |||
| /// Commit database transaction and snapshot if it exists. | |||
| pub fn commit(self) -> ProviderResult<bool> { | |||
| self.0.snapshot_provider.commit()?; | |||
There was a problem hiding this comment.
I like this, this is a lot cleaner now imo
shekhirin
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SnapshotProvider::commit()from insideDatabaseProviderRW::commit(smell)SnapshotProvider::commit()beforeDatabaseProviderRW::commiton stage completion/unwindcommit()from inside the Header and Bodies stage. It's redundant since the stage will commit it once the run is done. And doing too many times adds up on BodyStage, since underneath it will callfsyncdata written to static files needs to be committed before it can be used. Only then will it update theSnapshotProvideron the new available tx or block range.