-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SegmentHeader
block range is now an Option<_>
#6738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-bug
An unexpected or incorrect behavior
A-static-files
Related to static files
labels
Feb 22, 2024
shekhirin
reviewed
Feb 22, 2024
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
onbjerg
reviewed
Feb 22, 2024
you mentioned that we can apply this fix w/o resyncing, can you document the procedure for that in the PR? |
shekhirin
reviewed
Feb 22, 2024
joshieDo
force-pushed
the
joshie/option-block-range
branch
from
February 22, 2024 16:21
562c842
to
7ed977e
Compare
shekhirin
reviewed
Feb 22, 2024
shekhirin
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one metrics nit
mattsse
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
SnapshotProviderRW
creates a new file, it commits the configuration before it can be used. Andblock_range
was being initialized asblock.start..=block.start
.However, there is the case that if the node is interrupted before the first commit of a new file, then on restart, the node would return the wrong highest block of the segment. It would return
block.start
, when in fact it's just an empty file.This would have consequences when calling
get_snapshot_target
, where it would assume that we needblock.start + 1 -> tip
data.Changing
SegmentHeader
block_range to an option should fix this.This will cause existing nodes on
feat/static-files
to be incompatible with this change, since the configuration file format changedTo make this less painful, I'll create a small cli tool that can generate configuration files (
conf
) with the same ranges, and so they can replace the existing ones.--
fsync
to disk