Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure we only prune unfinalized data (wrt hive) #6788

Merged
merged 5 commits into from
Feb 26, 2024
Merged

fix: make sure we only prune unfinalized data (wrt hive) #6788

merged 5 commits into from
Feb 26, 2024

Conversation

joshieDo
Copy link
Collaborator 

 // Prevents a scenario where the pruner correctly starts at a finalized block,
 // but the first transaction (tx_num = 0) only appears on an unfinalized one.
 // Should only happen on a test/hive scenario.

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-pruning Related to pruning or full node labels Feb 26, 2024
Base automatically changed from alexey/remove-static-files-stage to feat/static-files February 26, 2024 13:03
@joshieDo joshieDo added the A-static-files Related to static files label Feb 26, 2024
@shekhirin shekhirin merged commit 17ad869 into feat/static-files Feb 26, 2024
23 of 25 checks passed
@shekhirin shekhirin deleted the joshie/fix-hive-prune branch February 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@shekhirin shekhirin shekhirin approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@Rjected Rjected Awaiting requested review from Rjected

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-pruning Related to pruning or full node A-static-files Related to static files C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshieDo @shekhirin @onbjerg @mattsse