Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): fix clap deprecated warnings #6872

Merged
merged 4 commits into from
Feb 29, 2024
Merged

chore(cli): fix clap deprecated warnings #6872

merged 4 commits into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. chore: #[clap] -> #[command], #[arg] 

    warning: use of deprecated function `<commands::db::get::Command as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> bin/reth/src/commands/db/get.rs:27:7
   |
27 |     #[clap(long)]
   |       ^^^^
   |
   = note: `#[warn(deprecated)]` on by default
    @DaniPopes
    DaniPopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e7ebac1 View commit details
    Browse the repository at this point in the history

  2. chore: #[arg(name)] -> #[arg(id)] 

    warning: use of deprecated function `<args::network_args::DiscoveryArgs as clap::Args>::augment_args::id_is_only_for_arg`: `#[arg(name)] was allowed by mistake, instead use `#[arg(id)]` or `#[arg(value_name)]`
   --> crates/node-core/src/args/network_args.rs:218:36
    |
218 |     #[arg(long = "discovery.port", name = "discovery.port", value_name = "DISCOVERY_PORT", default_value_t = DEFAULT_DISCOVERY_PORT)]
    |                                    ^^^^
    @DaniPopes
    DaniPopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    103df4c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into dani/clap-deprecated

    @shekhirin
    shekhirin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5bbf8f1 View commit details
    Browse the repository at this point in the history

  4. arg -> command for rollupargs

    @shekhirin
    shekhirin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    552dfd5 View commit details
    Browse the repository at this point in the history