feat: impl TryFrom<reth_rpc_types::Transaction> for Transaction #7551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbnerZheng
commented
Apr 10, 2024
| } | ||
| Some(3u8) => { | ||
| // EIP-4844 | ||
| Ok(Transaction::Eip4844(TxEip4844 { |
There was a problem hiding this comment.
3u8 should be the type for Eip4844? The document here should be updated?
https://github.com/alloy-rs/alloy/blob/main/crates/rpc-types/src/eth/transaction/mod.rs#L106C5-L116C38
shekhirin
added
C-enhancement
shekhirin
reviewed
Apr 10, 2024
mattsse
requested changes
Apr 10, 2024
| Ok(Transaction::Legacy(TxLegacy { | ||
| chain_id: tx.chain_id, | ||
| nonce: tx.nonce, | ||
| gas_price: tx.gas_price.ok_or(ConversionError::MissingGasPrice)?, |
There was a problem hiding this comment.
this is a bit dangerous, because gasprice is commonly set for all tx types, so this match arm should check if there are any 1559 fields present, if so return an error
|
|
||
| fn try_from(tx: reth_rpc_types::Transaction) -> Result<Self, Self::Error> { | ||
| match tx.transaction_type { | ||
| None => { |
There was a problem hiding this comment.
Suggested change
| None => { | |
| None | Some(0u8) => { |
| value: tx.value, | ||
| access_list: tx.access_list.ok_or(ConversionError::MissingAccessList)?.into(), | ||
| input: tx.input, | ||
| blob_versioned_hashes: tx.blob_versioned_hashes.unwrap_or_default(), |
There was a problem hiding this comment.
this should also be an error ref alloy-rs/alloy#506
mattsse
approved these changes
Apr 12, 2024
|
also need to update evm-inspector rev pin... |
3 tasks
mattsse
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7214