Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): pass changesets to unwind methods #7879

Merged
merged 4 commits into from
Oct 29, 2024
Merged

feat(storage): pass changesets to unwind methods #7879

merged 4 commits into from
Oct 29, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Apr 25, 2024 •
edited
Loading

Deduplicates the querying of changesets when unwinding in the blockchain tree by querying them once for accounts and once for storages, and then passing to the corresponding unwind methods.

@shekhirin shekhirin added C-perf A change motivated by improving speed, memory usage or disk footprint A-db Related to the database labels Apr 25, 2024
@shekhirin shekhirin requested review from mattsse and rkrasiuk April 25, 2024 14:46
@shekhirin shekhirin marked this pull request as ready for review April 25, 2024 15:19
emhane
emhane approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin
Copy link
Collaborator Author

@mattsse @rkrasiuk PTAL

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 10, 2024
@joshieDo joshieDo added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jul 12, 2024
@shekhirin shekhirin requested a review from gakonst as a code owner October 29, 2024 12:56
@shekhirin shekhirin force-pushed the alexey/provider-unwind-dedup branch from 511ee3a to db6ffc1 Compare October 29, 2024 12:56
@shekhirin shekhirin force-pushed the alexey/provider-unwind-dedup branch from db6ffc1 to 02a2ff4 Compare October 29, 2024 12:56
@shekhirin shekhirin added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 5232842 Oct 29, 2024
40 checks passed
@shekhirin shekhirin deleted the alexey/provider-unwind-dedup branch October 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane emhane approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-db Related to the database C-perf A change motivated by improving speed, memory usage or disk footprint M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shekhirin @mattsse @emhane @joshieDo