fix: add checks for hardfork-specific fields to ensure_well_formed_payload #7993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
fgimenez
force-pushed
the
fgimenez/do-not-drop-subprotocol-msgs
branch
from
0463640
to
7407703
Compare
|
I initially added checks for all the conditions but needed to remove these bc of failing tests:
|
mattsse
requested changes
May 3, 2024
fgimenez
force-pushed
the
fgimenez/do-not-drop-subprotocol-msgs
branch
from
be74024
to
d1f6972
Compare
3 tasks
mattsse
approved these changes
May 6, 2024
mattsse
added a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
May 6, 2024
required for foundry-rs/foundry#7867 also includes new fn for paradigmxyz/reth#7993 cc @fgimenez
cool thx, already proposed bump alloy here #8118 |
fgimenez
force-pushed
the
fgimenez/do-not-drop-subprotocol-msgs
branch
from
d1f6972
to
466dd78
Compare
ok rebased and already using cancun_fields.as_ref |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks to
ensure_well_formed_payload()to ensure that the Cancun specific fields fields areNonebefore Cancun andSome()afterwards.Additionally, adds checks for the Shanghai fork to ensure that withdrawals are not included before this timestamp and are included afterwards.
Also ensure
cancun_fields.fieldsisNonebefore Cancun andSome()afterwards.