-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(net): add Framed ECIES implementation #80
Conversation
7c02c35
to
a3342b4
Compare
a3342b4
to
cd8f07f
Compare
* adds std feature to reth-rlp
6bb8176
to
fc89dd6
Compare
remove anyhow and strictly type all errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it post refactor
crates/net/ecies/Cargo.toml
Outdated
[dependencies] | ||
reth-rlp = { path = "../../common/rlp", features = ["derive", "ethereum-types", "std"] } | ||
reth-primitives = { path = "../../primitives" } | ||
anyhow = "1.0.65" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eyre
repository = "https://github.com/foundry-rs/reth" | ||
readme = "README.md" | ||
|
||
[dependencies] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of these deps required?
This depends on #79 (do not merge until #79 is in), and extracts out the ECIES implementation from
devp2p-rs
pre-GPL.This is changed slightly, no longer using the
Transport
trait and instead specifying thatIo
isAsyncRead
orAsyncWrite
or both, depending on the situation.For example, when implementing
Stream
,Io
should beAsyncRead + Unpin
, and when implementingSink
,Io
should beAsyncWrite + Unpin
.A
HasRemoteAddr
trait is created, which is just used for tracing instrumentation, since the current instruments rely on theIo
having aremote_addr
method.