Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): add Framed ECIES implementation #80

Merged
merged 15 commits into from
Oct 16, 2022
Merged

feat(net): add Framed ECIES implementation #80

merged 15 commits into from
Oct 16, 2022

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 15, 2022

This depends on #79 (do not merge until #79 is in), and extracts out the ECIES implementation from devp2p-rs pre-GPL.

This is changed slightly, no longer using the Transport trait and instead specifying that Io is AsyncRead or AsyncWrite or both, depending on the situation.
For example, when implementing Stream, Io should be AsyncRead + Unpin, and when implementing Sink, Io should be AsyncWrite + Unpin.

A HasRemoteAddr trait is created, which is just used for tracing instrumentation, since the current instruments rely on the Io having a remote_addr method.

@Rjected Rjected changed the title feat(primitives): add Framed ECIES implementation feat(net): add Framed ECIES implementation Oct 15, 2022
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it post refactor

[dependencies]
reth-rlp = { path = "../../common/rlp", features = ["derive", "ethereum-types", "std"] }
reth-primitives = { path = "../../primitives" }
anyhow = "1.0.65"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyre

repository = "https://github.com/foundry-rs/reth"
readme = "README.md"

[dependencies]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of these deps required?

@gakonst gakonst mentioned this pull request Oct 16, 2022
23 tasks
@gakonst gakonst merged commit 5dfe5ac into main Oct 16, 2022
@gakonst gakonst deleted the dan/add-ecies branch October 16, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants