Implement ETH P2P #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 16, 2022
crates/net/eth-wire/src/stream.rs
Outdated
Comment on lines
15
to
17
| struct EthStream<S> { | ||
| stream: S, | ||
| } |
There was a problem hiding this comment.
this could just be a new type wrapper Framed with a EthMessage codec.
|
Does making the Eth protocol a codec let us "layer" codecs together? i.e. I'd like to be able to add any extra messaging protocol on top of the ecies stream, and vice versa, i.e. be able to use an arbitrary encryption codec for my higher level messaging protocol |
mattsse
force-pushed
the
gakonst/eth-protocol
branch
from
77e2f06
to
7c03354
Compare
we were rlp encoding twice
This reverts commit 6e6e0a5. This does not handle framing, which would fail decoding if a partial write happened to the socket.
|
summarizing some notes:
|
we can instead use LengthLimitedCodec from Tokio IO, which we re-export as PassthroughCodec
1. 10MB message lengths 2. Same Genesis, Version, Chain on Status Handshake
yutianwu
pushed a commit
to yutianwu/reth
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #64
Introduces a new
EthStreamtype that wraps around aStreamandSinkimplementation and proceeds to RLP encode/decode messages over each line.TODO
Follow-up PRs: Rest of messages.