feat: prague engine api types #8119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
C-enhancement
onbjerg
force-pushed
the
onbjerg/engine-api-prague
branch
from
1d0c430
to
ed189d9
Compare
onbjerg
commented
May 6, 2024
Comment on lines
+502
to
+503
| // TODO(onbjerg): Implement `ExecutionPayloadV4` support | ||
| todo!() |
There was a problem hiding this comment.
for a follow up we should implement this for the beacon types, since this is not strictly necessary for the engine api (this is not used in that code path)
onbjerg
removed
the
S-blocked
onbjerg
force-pushed
the
onbjerg/engine-api-prague
branch
2 times, most recently
from
504ee2a
to
aea81af
Compare
DaniPopes
pushed a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
May 6, 2024
Needed for paradigmxyz/reth#8119
onbjerg
force-pushed
the
onbjerg/engine-api-prague
branch
from
11d2a4a
to
bd7d707
Compare
|
@onbjerg still blocked? |
|
nop, rfr, obviously still work to do, |
rkrasiuk
reviewed
May 6, 2024
| // not do anything special here to handle them | ||
| try_payload_v3_to_block(payload.payload_inner) | ||
| } | ||
|
|
||
| /// Converts [SealedBlock] to [ExecutionPayload] | ||
| pub fn block_to_payload(value: SealedBlock) -> ExecutionPayload { |
There was a problem hiding this comment.
this function needs adjustment as well
There was a problem hiding this comment.
used in reorg sim, will adjust it in #8053
rkrasiuk
approved these changes
May 6, 2024
This was referenced May 6, 2024
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
engine_newPayloadV4engine_getPayloadV4