Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add op-reth to release workflow #8132

Merged
merged 2 commits into from
May 8, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented May 6, 2024

Adds op-reth to the release workflow, for both binaries and the docker push workflow

Closes #8064

@Rjected Rjected added C-enhancement New feature or request A-op-reth Related to Optimism and op-reth labels May 6, 2024
@Rjected Rjected force-pushed the dan/create-op-reth-release-workflow branch from 6a4a4a2 to 64ea0b7 Compare May 6, 2024 22:27
@Rjected Rjected marked this pull request as ready for review May 6, 2024 22:28
@Rjected
Copy link
Member Author

Rjected commented May 6, 2024

validating that:

for asset in ./*reth-*.tar.gz*; do

works

@Rjected Rjected force-pushed the dan/create-op-reth-release-workflow branch from 64ea0b7 to 95bd8c1 Compare May 6, 2024 22:44
@@ -34,18 +35,53 @@ jobs:
- target: x86_64-unknown-linux-gnu
os: ubuntu-20.04
profile: maxperf
make-command: build
binary: reth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move from include[].binary to binary: ["reth", "op-reth"]

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree w @DaniPopes otherwise lgtm

@Rjected Rjected force-pushed the dan/create-op-reth-release-workflow branch from 95bd8c1 to b164665 Compare May 8, 2024 13:39
@Rjected Rjected added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 331d1a0 May 8, 2024
28 checks passed
@Rjected Rjected deleted the dan/create-op-reth-release-workflow branch May 8, 2024 14:39
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship op-reth in release workflow
4 participants