-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add op-reth to release workflow #8132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
New feature or request
A-op-reth
Related to Optimism and op-reth
labels
May 6, 2024
Rjected
force-pushed
the
dan/create-op-reth-release-workflow
branch
from
May 6, 2024 22:27
6a4a4a2
to
64ea0b7
Compare
validating that:
works |
Rjected
force-pushed
the
dan/create-op-reth-release-workflow
branch
from
May 6, 2024 22:44
64ea0b7
to
95bd8c1
Compare
DaniPopes
reviewed
May 7, 2024
.github/workflows/release.yml
Outdated
@@ -34,18 +35,53 @@ jobs: | |||
- target: x86_64-unknown-linux-gnu | |||
os: ubuntu-20.04 | |||
profile: maxperf | |||
make-command: build | |||
binary: reth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move from include[].binary
to binary: ["reth", "op-reth"]
onbjerg
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree w @DaniPopes otherwise lgtm
mattsse
approved these changes
May 7, 2024
Rjected
force-pushed
the
dan/create-op-reth-release-workflow
branch
from
May 8, 2024 13:39
95bd8c1
to
b164665
Compare
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds op-reth to the release workflow, for both binaries and the docker push workflow
Closes #8064