feat(eth): add remaining eth protocol message types #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 17, 2022
gakonst
commented
Oct 17, 2022
Rjected
force-pushed
the
gakonst/eth-remaining-msgs
branch
from
6c54310
to
5e3743e
Compare
mattsse
requested changes
Oct 18, 2022
onbjerg
added
C-enhancement
Rjected
force-pushed
the
gakonst/eth-remaining-msgs
branch
2 times, most recently
from
8fe6205
to
6303e80
Compare
* encoding / decoding still todo
* also add Hash to more types
* TODO: refactor tests and make tests pass
Rjected
force-pushed
the
gakonst/eth-remaining-msgs
branch
from
6303e80
to
4626fdf
Compare
* do not hash the entire buffer
* apply a clippy fix
gakonst
commented
Oct 20, 2022
Comment on lines
+51
to
+52
| /// The current total difficulty. | ||
| pub td: U128, |
There was a problem hiding this comment.
What is this value post merge?Did anything change in how p2p works?
There was a problem hiding this comment.
these messages (NewBlock) shouldn't be broadcast post-merge
There was a problem hiding this comment.
Got it - let's consider feature gating them later on if we think that's right.
Comment on lines
+5
to
+6
| /// This message was removed in `eth/67`, only clients running `eth/66` or earlier will respond to | ||
| /// this message. |
There was a problem hiding this comment.
Should we implement both? If we don't do eth/66, then we should remove this request right?
There was a problem hiding this comment.
Yes, if we don't do eth/66 then we should remove these. I'm open minded to removing this message and supporting only eth/67. I'm not sure if clients that implement eth/66 even use this message either.
* use partition in split_transaction_by_hashes instead of peekable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP