Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove BundleStateInit dup in take/get/remove_state methods #9464

Merged
merged 1 commit into from
Jul 12, 2024
Merged

chore: remove BundleStateInit dup in take/get/remove_state methods #9464

merged 1 commit into from
Jul 12, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jul 11, 2024

Now that the methods are separate, they can reuse code. Operates over a RO tx, so both reading and writing methods can use them

@Rjected Rjected added C-enhancement New feature or request A-db Related to the database labels Jul 11, 2024
@Rjected Rjected added C-debt Refactor of code section that is hard to understand or maintain and removed C-enhancement New feature or request labels Jul 11, 2024
@joshieDo joshieDo added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 91aa8bb Jul 12, 2024
33 checks passed
@joshieDo joshieDo deleted the dan/dedup-some-duplication branch July 12, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-db Related to the database C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @mattsse @joshieDo