perf(tree): re-use intermediate nodes #9836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
rkrasiuk
changed the title
rkrasiuk
changed the title
rkrasiuk
added
C-perf
rkrasiuk
force-pushed
the
rkrasiuk/overlay-root-with-intermediate-nodes
branch
from
6564040
to
29a4823
Compare
rkrasiuk
requested review from
joshieDo,
rakita,
shekhirin,
mattsse,
Rjected,
emhane and
fgimenez
as code owners
rkrasiuk
changed the title
gakonst
approved these changes
Jul 29, 2024
Comment on lines
27
to
44
| let mut trie_updates = TrieUpdates::default(); | ||
| for block in &in_memory { | ||
| hashed_post_state.extend(block.hashed_state.as_ref().clone()); | ||
| trie_updates.extend(block.trie.as_ref().clone()); | ||
| } |
There was a problem hiding this comment.
we can use Arc around the trie update and hashed post state in the ExecutedBlock type
mattsse
approved these changes
Jul 29, 2024
rkrasiuk
force-pushed
the
rkrasiuk/overlay-root-with-intermediate-nodes
branch
from
973a602
to
318c938
Compare
rkrasiuk
force-pushed
the
rkrasiuk/overlay-root-with-intermediate-nodes
branch
from
43ee877
to
ea67709
Compare
mattsse
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Computation of overlay root with cached intermediate nodes. Will likely be broken down into smaller PRs.