fix: set finalized & safe block information on startup #9873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
rakita,
joshieDo,
shekhirin,
rkrasiuk and
Rjected
as code owners
joshieDo
approved these changes
Jul 29, 2024
mattsse
commented
Jul 29, 2024
Comment on lines
402
to
411
| let genesis_block = self.base_config.chain_spec.genesis_header().seal_slow(); | ||
| let finalized_block = genesis_block.clone(); | ||
|
|
||
| let blockchain_provider = BlockchainProvider::with_block_information( | ||
| provider_factory.clone(), | ||
| tree, | ||
| genesis_block, | ||
| Some(finalized_block), | ||
| ) | ||
| .expect("failed to create blockchain provider"); |
There was a problem hiding this comment.
why do we need to update this?
is None, not sufficient?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #9105